use current language if Language is not passed#167
Merged
Conversation
Member
|
late here, sorry, but indeed I would avoid an dependency indirection to plone.api here. |
Contributor
Author
|
I have removed the dependency and copied the code in plone.api to get the current language |
…dynamics#166) Adds regression tests for erral's fix: when a query has no Language, _handle_text falls back to get_current_language() (request/site/default), and an explicit Language still wins. Plus unit tests for the vendored get_current_language helper. Co-authored-by: Mikel Larreategi <erral@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
I introduce here a dependency on plone.api, but we can remove it and use the implementation that plone.api uses to get the current language.